-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #7075: Plugin - Accommodate new oneclick exclusions UI for delayjs #7090
Closes #7075: Plugin - Accommodate new oneclick exclusions UI for delayjs #7090
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Automated testing passes with the new data structure, awaiting backend implementation to be sure it truly passes for manual testing. |
Icons implementation pending. |
@jeawhanlee I don't have access to this Figma. Checking with @DahmaniAdame if he has |
@piotrbak I don't. Ben was the only one with access to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Icons image sizes are not exactly the same which is causing not good UI:
Can we make sure that the size is 16X16 so it has no UI problems?
also I can see that not all of them are images but some of them are dashicons so make sure that their width and height are exactly the same too and if it's not working properly with dashicons convert all of them to be images.
what do u think?
@jeawhanlee Thanks for the update, rollback is good now. But Ads and other icons do not match the ones here #7090 (comment) |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Thanks @jeawhanlee , Icons are matching the slack thread now |
Description
Fixes #7075
Explain how this code impacts users.
Type of change
Detailed scenario
N/A
Technical description
Documentation
This code adds a parent category to the scripts and adapts compatibility with the new delayjs backend exclusion list structure. it also adds some enhancement to the UI/UX.
New dependencies
N/A
Risks
N/A
Mandatory Checklist
Code validation
Code style
Additional Checks