Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google fonts option's label and docs urls #7182

Conversation

wordpressfan
Copy link
Contributor

Description

Closes https://github.com/orgs/wp-media/projects/109/views/1?pane=issue&itemId=90666760

This is a very minor change to update the option's label along with the docs urls.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

As mentioned, very minor, u need to check our settings page to make sure that the label is changed but for the docs, because they are not published yet, we just need to make sure that this is as mentioned in the draft issue.

Technical description

Documentation

N/A

New dependencies

N/A

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

Very minor change doesn't need any tests changes

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@wordpressfan wordpressfan self-assigned this Dec 12, 2024
@wordpressfan wordpressfan added this to the 3.18 milestone Dec 12, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -0.10%) 75.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0afcb6a) 38483 16906 43.93%
Head commit (111cd45) 38449 (-34) 16891 (-15) 43.93% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7182) 4 3 75.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@wordpressfan wordpressfan marked this pull request as ready for review December 12, 2024 11:36
@wordpressfan wordpressfan requested a review from a team December 12, 2024 11:37
@wordpressfan wordpressfan merged commit 1ed4478 into feature/host-google-fonts Dec 12, 2024
12 checks passed
@wordpressfan wordpressfan deleted the enhancement/option-label-and-docs-links branch December 12, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants