-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi tiers upgrade - part 2 #7195
Multi tiers upgrade - part 2 #7195
Conversation
change type to slug
@marija-nikolic attaching here how it looks like, please note that I mocked the prices and just added a few license types just for testing, so here we need a feedback on just the UI plz. Without active promo campaign: With active promo campaign: Let me know if u see any UI issue that needs to be fixed. |
Thank you! Screenshot of the current pop-up (for Single license): For dropdown, you can do the same Nicolas did for the account page: The dropdown should be narrower than the CTA, with a gray border around it (same line width and color as the large square). |
@wordpressfan Here is how open dropdown looks like: |
Adjusted all the points mentioned above: Without active promo campaign: multi-tiers-part2-marija-v2-2024-12-19_02.53.23.mp4With active promo campaign: multi-tiers-part2-marija-v2-promo-2024-12-19_02.55.08.mp4 |
Screencast after latest changes: multi-tiers-part2-marija-v3-2024-12-19_10.30.52.mp4 |
Thank you very much @wordpressfan Please make sure that the open dropdown menu is not wider: It seems the boxes are nearly square. Could you please check the height-to-width ratio and adjust it to match what we had before or use the ones on the account page as a reference? |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
I'm going to merge this one and prepare the main feature PR description as @marija-nikolic approved the current screenshots/screencasts. |
f33c2f4
into
feature/multi-tiers-upgrade
Description
Fixes #7177
UI changes for upgrade Multi tiers.
Type of change
Detailed scenario
Everything is mentioned in the issue.
Technical description
Documentation
We added custom-select new stylying/scripts to be exactly as in the website.
New dependencies
No
Risks
No
Mandatory Checklist
Code validation
Code style
Unticked items justification
If some mandatory items are not relevant, explain why in this section.
Additional Checks