-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close #6863 Add termly compatibility #7198
base: develop
Are you sure you want to change the base?
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good we have a unit test for this, but I think an integration test for this scenario would be helpful for testing with a html template containing that kind of link we are trying to exclude to see if the regex works properly.
@Khadreal Thanks for the PR. using the PR , can see that termly script is not excluded from deferjs /delay js |
@Mai-Saad pushed a fix and tested that it's working now. |
Description
Exclude Termly from delay and defer when applicable.
Fixes #6863
Type of change
Detailed scenario
Check #6863
Technical description
Documentation
Exclude Termly resources if
termly_display_auto_blocker
is set 'on'Mandatory Checklist
Code validation
Code style