Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import org.graalvm.polyglot package and sub-packages #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Import org.graalvm.polyglot package and sub-packages #193

wants to merge 1 commit into from

Conversation

shanggeeth
Copy link
Contributor

Purpose

  • We need to bundle graal-sdk as an OSGi bundle and expose only the selected packages.
  • So required packages need to be imported.
  • This PR adds the required imports

Related Issue

@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.09%. Comparing base (3da0fea) to head (7068a1a).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #193   +/-   ##
=========================================
  Coverage     43.09%   43.09%           
  Complexity       86       86           
=========================================
  Files            22       22           
  Lines          1188     1188           
  Branches        116      116           
=========================================
  Hits            512      512           
  Misses          625      625           
  Partials         51       51

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shanggeeth shanggeeth mentioned this pull request Oct 14, 2024
Open
@shanggeeth shanggeeth force-pushed the master branch 2 times, most recently from 8ca09ad to 175b454 Compare November 4, 2024 16:34
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11668554244

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11668554244
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11668554244

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11668554244
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11668554244

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11668554244
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11668554244

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11668554244
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Nov 5, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11668554244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@janakamarasena janakamarasena janakamarasena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shanggeeth @jenkins-is-staging @janakamarasena