Feature dpop rest #74

kalanika · 2021-08-24T15:26:04Z

Purpose

Implemented DPoP token support according to the spec https://tools.ietf.org/html/draft-ietf-oauth-dpop-02

CLAassistant · 2021-08-24T15:26:08Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ isuruhettiarachchi
✅ kalanika
✅ nipunthathsara
❌ darsham3
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

...tity.dpop/src/main/java/org/wso2/carbon/identity/dpop/handler/DPoPAuthenticationHandler.java

...so2.carbon.identity.dpop/src/main/java/org/wso2/carbon/identity/dpop/constant/Constants.java

...identity.dpop/src/main/java/org/wso2/carbon/identity/dpop/internal/DPoPServiceComponent.java

...p/src/main/java/org/wso2/carbon/identity/dpop/listener/OauthDPoPInterceptorHandlerProxy.java

...tity.dpop/src/main/java/org/wso2/carbon/identity/dpop/handler/DPoPAuthenticationHandler.java

jenkins-is-staging · 2021-10-15T03:45:22Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/1344508770

...identity.dpop/src/main/java/org/wso2/carbon/identity/dpop/internal/DPoPServiceComponent.java

jenkins-is-staging · 2021-10-15T05:28:07Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/1344508770
Status: failure

jenkins-is-staging · 2021-10-15T14:54:50Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/1346396415

jenkins-is-staging · 2021-10-15T16:30:44Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/1346396415
Status: success

jenkins-is-staging

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/1346396415

piraveena · 2021-10-21T08:14:25Z

Can you add a readme file with all the instructions inside the dpop component? It will be helpful for the people to refer. Also, can you add the java client you used to generate the DPoP header inside the sample-is repo and refer to that from the readme file?

...dentity.dpop/src/main/java/org/wso2/carbon/identity/dpop/validators/DPoPHeaderValidator.java

...p/src/main/java/org/wso2/carbon/identity/dpop/listener/OauthDPoPInterceptorHandlerProxy.java

...dentity.dpop/src/main/java/org/wso2/carbon/identity/dpop/validators/DPoPHeaderValidator.java

kalanika · 2021-10-27T04:28:39Z

Can you add a readme file with all the instructions inside the dpop component? It will be helpful for the people to refer. Also, can you add the java client you used to generate the DPoP header inside the sample-is repo and refer to that from the readme file?
Added the readme file README.md
Java client PR : DPoP-client-app

chamathns · 2021-11-05T10:26:11Z

Shall we change the implementation to read the configs that were included in the wso2/carbon-identity-framework#3805 and wso2/carbon-identity-framework#3800 as custom configs from the deployment.toml file?

The reason being, since DPoP is still at its draft state, it's not ideal to have the configurations added to the framework side at the moment. So, the alternative would be to instruct anyone who's going to use the DPoP module to include the necessary params in the deployment.toml as custom configs.

piraveena · 2021-11-12T04:24:07Z

component/org.wso2.carbon.identity.dpop/README.md

+type = "dpop"
+class = "org.wso2.carbon.identity.dpop.validators.DPoPTokenValidator"
+
+[oauth.grant_type.uma_ticket]


Can you explain the reason for using uma config here?

In order to enable the custom introspection data provider.

darsham3 and others added 20 commits March 11, 2021 20:36

add oauth2 dpop extension

d99b7b3

add dpop validity check

91cde75

code clean up

12d54b5

Enforce dpop based on application's config

db91196

fix alogorithm names

6b79c37

fix in dpop token issue interceptor

944845f

Refactor DPoP interceptor handler

3e2e7da

Fix dependency and OSGI issues

9a9041c

Fix styles and reviews

1d28270

Add constants

ef957f5

Register DPoPAuthenticationHandler

bbe832b

Fix validateDPoPPayload

80fd4be

Add dependency

69b96a5

Fix dependency and OSGI issues

b98a63c

Add DPoPAuthenticationHandler

abdf65d

Remove dynamic imports and fix dependency issues

f9bbb5e

Add Javadoc comment in DPoPAuthenticationHandler

3c6e56d

Add checkstyle plugin

d77f2b2

Add code imporvements

b2bb2d7

Add comment line

b655aa1

Add changes to the if condition and canHandle method

e04ec7c

kalanika force-pushed the feature-dpop-rest branch from 5d6c930 to e04ec7c Compare August 25, 2021 05:46

nipunthathsara suggested changes Sep 5, 2021

View reviewed changes

Add dao package and other changes

c63ad83

kalanika force-pushed the feature-dpop-rest branch from c236cdd to c63ad83 Compare September 8, 2021 19:59

kalanika added 4 commits September 9, 2021 01:46

Add doc comments and remove static,unused imports

17afe5c

Remove checkstyle plugin and format pom file

ddb7772

Fix validateSignature method

e168296

Change validateSignature mentod signature

4cfb8c3

piraveena reviewed Oct 15, 2021

View reviewed changes

...identity.dpop/src/main/java/org/wso2/carbon/identity/dpop/internal/DPoPServiceComponent.java Outdated Show resolved Hide resolved

kalanika mentioned this pull request Oct 15, 2021

Add dpop related configurations wso2/carbon-identity-framework#3800

Merged

jenkins-is-staging approved these changes Oct 15, 2021

View reviewed changes

chamathns reviewed Oct 22, 2021

View reviewed changes

...dentity.dpop/src/main/java/org/wso2/carbon/identity/dpop/validators/DPoPHeaderValidator.java Outdated Show resolved Hide resolved

kalanika force-pushed the feature-dpop-rest branch from 01200cb to eb59bee Compare October 22, 2021 09:18

Add code improvement changes

28e223c

kalanika force-pushed the feature-dpop-rest branch from eb59bee to 28e223c Compare October 22, 2021 09:22

chamathns reviewed Oct 23, 2021

View reviewed changes

...p/src/main/java/org/wso2/carbon/identity/dpop/listener/OauthDPoPInterceptorHandlerProxy.java Outdated Show resolved Hide resolved

chamathns reviewed Oct 23, 2021

View reviewed changes

...dentity.dpop/src/main/java/org/wso2/carbon/identity/dpop/validators/DPoPHeaderValidator.java Outdated Show resolved Hide resolved

chamathns reviewed Oct 23, 2021

View reviewed changes

...dentity.dpop/src/main/java/org/wso2/carbon/identity/dpop/validators/DPoPHeaderValidator.java Outdated Show resolved Hide resolved

chamathns approved these changes Oct 23, 2021

View reviewed changes

Add infor log and return string.empty

7e54c4e

kalanika mentioned this pull request Oct 25, 2021

Add dpop listener enable configurations wso2/carbon-identity-framework#3805

Merged

Change isEnable config

28d18c3

chamathns requested review from mefarazath and piraveena October 26, 2021 13:13

piraveena approved these changes Oct 27, 2021

View reviewed changes

Add configuration related code level changes

16eb191

kalanika force-pushed the feature-dpop-rest branch from 36209d1 to 16eb191 Compare November 10, 2021 12:09

Add readme file

2f463c8

piraveena reviewed Nov 12, 2021

View reviewed changes

kalanika force-pushed the feature-dpop-rest branch from 5a88e13 to 2f463c8 Compare November 22, 2021 08:36

chamathns merged commit 9e797a7 into wso2-extensions:master Nov 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature dpop rest #74

Feature dpop rest #74

kalanika commented Aug 24, 2021 •

edited

Loading

CLAassistant commented Aug 24, 2021 •

edited

Loading

jenkins-is-staging commented Oct 15, 2021

jenkins-is-staging commented Oct 15, 2021

jenkins-is-staging commented Oct 15, 2021

jenkins-is-staging commented Oct 15, 2021

jenkins-is-staging left a comment

piraveena commented Oct 21, 2021 •

edited

Loading

kalanika commented Oct 27, 2021 •

edited

Loading

chamathns commented Nov 5, 2021

piraveena Nov 12, 2021

kalanika Nov 12, 2021

Feature dpop rest #74

Feature dpop rest #74

Conversation

kalanika commented Aug 24, 2021 • edited Loading

Purpose

CLAassistant commented Aug 24, 2021 • edited Loading

jenkins-is-staging commented Oct 15, 2021

jenkins-is-staging commented Oct 15, 2021

jenkins-is-staging commented Oct 15, 2021

jenkins-is-staging commented Oct 15, 2021

jenkins-is-staging left a comment

Choose a reason for hiding this comment

piraveena commented Oct 21, 2021 • edited Loading

kalanika commented Oct 27, 2021 • edited Loading

chamathns commented Nov 5, 2021

piraveena Nov 12, 2021

Choose a reason for hiding this comment

kalanika Nov 12, 2021

Choose a reason for hiding this comment

kalanika commented Aug 24, 2021 •

edited

Loading

CLAassistant commented Aug 24, 2021 •

edited

Loading

piraveena commented Oct 21, 2021 •

edited

Loading

kalanika commented Oct 27, 2021 •

edited

Loading