Merge pull request #517 from Kirishikesan/fix-4962

Changes spaces to hyphens in space included urls and Sets validation errors to empty array when url is valid
wso2 · Nov 28, 2023 · 95fe26a · 95fe26a
2 parents ba9629d + 4daaccb
commit 95fe26a
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/...er/src/main/webapp/source/src/app/components/Apis/Create/OpenAPI/Steps/ProvideOpenAPI.jsx b/...er/src/main/webapp/source/src/app/components/Apis/Create/OpenAPI/Steps/ProvideOpenAPI.jsx
@@ -127,6 +127,7 @@ export default function ProvideOpenAPI(props) {
                     info.content = content;
                     inputsDispatcher({ action: 'preSetAPI', value: info });
                     setValidity({ ...isValid, url: null });
+                    setValidationErrors([]);
                 } else {
                     setValidity({ ...isValid, url: { message: 'OpenAPI content validation failed!' } });
                     setValidationErrors(errors);

diff --git a/...src/main/webapp/source/src/app/components/Apis/Details/APIDefinition/APISecurityAudit.jsx b/...src/main/webapp/source/src/app/components/Apis/Details/APIDefinition/APISecurityAudit.jsx
@@ -192,7 +192,7 @@ class APISecurityAudit extends Component {
                     id: 'Apis.Details.APIDefinition.AuditApi.GetReportError',
                     defaultMessage: 'Something went wrong while retrieving the API Security Report',
                 }));
-                const redirectUrl = '/apis/' + apiId + '/api definition';
+                const redirectUrl = '/apis/' + apiId + '/api-definition';
                 history.push(redirectUrl);
             });
     }

diff --git a/...webapp/source/src/app/components/Apis/Details/Resources/components/GoToDefinitionLink.jsx b/...webapp/source/src/app/components/Apis/Details/Resources/components/GoToDefinitionLink.jsx
@@ -43,7 +43,7 @@ export default function GoToDefinitionLink(props) {
     const classes = useStyles();
     return (
         <Box m={1}>
-            <Link to={`/apis/${api.id}/api definition`}>
+            <Link to={`/apis/${api.id}/api-definition`}>
                 <Typography className={classes.link} variant='caption'>
                     {message}
                     <LaunchIcon style={{ marginLeft: '2px' }} fontSize='small' />

diff --git a/.../webapp/source/src/app/components/Apis/Details/components/leftMenu/DevelopSectionMenu.jsx b/.../webapp/source/src/app/components/Apis/Details/components/leftMenu/DevelopSectionMenu.jsx
@@ -173,7 +173,7 @@ export default function DevelopSectionMenu(props) {
                                 id: 'Apis.Details.index.business.info',
                                 defaultMessage: 'business info',
                             })}
-                            to={pathPrefix + 'business info'}
+                            to={pathPrefix + 'business-info'}
                             Icon={<BusinessIcon />}
                             id='left-menu-itembusinessinfo'
                         />

diff --git a/portals/publisher/src/main/webapp/source/src/app/components/Apis/Details/index.jsx b/portals/publisher/src/main/webapp/source/src/app/components/Apis/Details/index.jsx
@@ -376,7 +376,7 @@ class Details extends Component {
                     defaultMessage: 'API definition',
                 })}
                 route='api definition'
-                to={pathPrefix + 'api definition'}
+                to={pathPrefix + 'api-definition'}
                 Icon={<CodeIcon />}
                 id='left-menu-itemAPIdefinition'
             />
@@ -1017,9 +1017,9 @@ Details.subPaths = {
     BASE_PRODUCT: '/api-products/:apiprod_uuid',
     OVERVIEW: '/apis/:api_uuid/overview',
     OVERVIEW_PRODUCT: '/api-products/:apiprod_uuid/overview',
-    API_DEFINITION: '/apis/:api_uuid/api definition',
+    API_DEFINITION: '/apis/:api_uuid/api-definition',
     WSDL: '/apis/:api_uuid/wsdl',
-    API_DEFINITION_PRODUCT: '/api-products/:apiprod_uuid/api definition',
+    API_DEFINITION_PRODUCT: '/api-products/:apiprod_uuid/api-definition',
     SCHEMA_DEFINITION: '/apis/:api_uuid/schema definition',
     LIFE_CYCLE: '/apis/:api_uuid/lifecycle',
     LIFE_CYCLE_PRODUCT: '/api-products/:apiprod_uuid/lifecycle',
@@ -1042,8 +1042,8 @@ Details.subPaths = {
     SUBSCRIPTIONS: '/apis/:api_uuid/subscriptions',
     SECURITY: '/apis/:api_uuid/security',
     COMMENTS: '/apis/:api_uuid/comments',
-    BUSINESS_INFO: '/apis/:api_uuid/business info',
-    BUSINESS_INFO_PRODUCT: '/api-products/:apiprod_uuid/business info',
+    BUSINESS_INFO: '/apis/:api_uuid/business-info',
+    BUSINESS_INFO_PRODUCT: '/api-products/:apiprod_uuid/business-info',
     PROPERTIES: '/apis/:api_uuid/properties',
     PROPERTIES_PRODUCT: '/api-products/:apiprod_uuid/properties',
     NEW_VERSION: '/apis/:api_uuid/new_version',