Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new UI changes to tile feature #508

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

dulithsenanayake
Copy link
Contributor

No description provided.

</div>
</Popover>
</Popover>
)}
</div>
)}
{tileDisplayInfo.showTechnicalDetails && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean the configuration to hide owner details only applies to the technical owner, but not the business owner?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the popovers, we display the email of the business or technical owner if the user has provided their email. A configuration check is performed above to check whether the config is enabled for business or technical owners separately.
Eg: tileDisplayInfo.showBusinessDetails

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

@dulithsenanayake dulithsenanayake merged commit 87849f8 into wso2:main Oct 9, 2023
5 of 6 checks passed
YasasRangika pushed a commit to YasasRangika/apim-apps that referenced this pull request Dec 16, 2023
YasasRangika pushed a commit to YasasRangika/apim-apps that referenced this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants