Update SAMLSSOServiceProviderdAOImpl to use named parameters #5887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Osara-B
force-pushed
the
feature-remove-registry-saml
branch
from
438a239 to
7a768ac
Compare
darshanasbg
reviewed
Aug 27, 2024
| @@ -329,8 +329,8 @@ private boolean processIsServiceProviderExists(Connection connection, String iss | |||
|
|
|||
| try (NamedPreparedStatement statement = new NamedPreparedStatement(connection, | |||
| SAMLSSOServiceProviderConstants.SqlQueries.GET_SAML2_SSO_CONFIG_ID_BY_ISSUER)) { | |||
| statement.setString(1, issuer); | |||
| statement.setString(2, tenantUUID); | |||
| statement.setString("ISSUER", issuer); | |||
There was a problem hiding this comment.
Osara-B
force-pushed
the
feature-remove-registry-saml
branch
2 times, most recently
from
827ebcb to
afd4a6b
Compare
ImalshaG
reviewed
Sep 4, 2024
| @@ -24,67 +24,138 @@ private SAMLSSOServiceProviderConstants() { | |||
|
|
|||
| } | |||
|
|
|||
| public static class SAML2TableColumns { | |||
There was a problem hiding this comment.
Let's have an empty line here.
There was a problem hiding this comment.
darshanasbg
reviewed
Sep 4, 2024
|
|
||
| } | ||
|
|
||
| //IDN_SAML2_SSO table |
There was a problem hiding this comment.
…nts to use named parameters
Osara-B
force-pushed
the
feature-remove-registry-saml
branch
from
afd4a6b to
f02e487
Compare
darshanasbg
approved these changes
Sep 4, 2024
UdeshAthukorala
merged commit faf5a42
into
wso2:feature-remove-registry-saml
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
This PR introduces usage of named parameters in SAMLSSOServiceProviderDAOImpl.java. To support the transition from positional parameters to named parameters SAMLSSOServiceProvider.java is updated. This change improves code readability and maintainability.
-The refactored code replaces positional indices with named parameters.
-SQL queries are being executed using named parameters instead of positional indices.
Related to,