Update database setup and DAO implementation for schema changes #6014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darshanasbg
reviewed
Oct 11, 2024
...dentity.core/src/main/java/org/wso2/carbon/identity/core/model/SAMLSSOServiceProviderDO.java
Outdated
Show resolved
Hide resolved
darshanasbg
reviewed
Oct 11, 2024
features/identity-core/org.wso2.carbon.identity.core.server.feature/resources/dbscripts/h2.sql
Outdated
Show resolved
Hide resolved
Osara-B
force-pushed
the
saml-feature
branch
8 times, most recently
from
8a0a3f8 to
63d692c
Compare
Osara-B
force-pushed
the
saml-feature
branch
3 times, most recently
from
f19d15e to
c5b6b2d
Compare
Osara-B
force-pushed
the
saml-feature
branch
2 times, most recently
from
163ada5 to
518b934
Compare
There was a problem hiding this comment.
Copilot reviewed 3 out of 4 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- features/identity-core/org.wso2.carbon.identity.core.server.feature/resources/dbscripts/h2.sql: Language not supported
Comments skipped due to low confidence (3)
components/identity-core/org.wso2.carbon.identity.core/src/main/java/org/wso2/carbon/identity/core/model/SAMLSSOServiceProviderDO.java:83
- [nitpick] The constant name BACK_CHANNEL_LOGOUT_BINDING should be consistent with other naming conventions. Consider renaming it to BACKCHANNEL_LOGOUT_BINDING.
private static final String BACK_CHANNEL_LOGOUT_BINDING = "BackChannel";
components/identity-core/org.wso2.carbon.identity.core/src/main/java/org/wso2/carbon/identity/core/model/SAMLSSOServiceProviderDO.java:687
- The constant AUDIENCES is used incorrectly here. It should be RECIPIENTS.
putIfNotNull(customAttributes, AUDIENCES, requestedRecipient);
components/identity-core/org.wso2.carbon.identity.core/src/main/java/org/wso2/carbon/identity/core/model/SAMLSSOServiceProviderDO.java:733
- The constant AUDIENCES is used incorrectly here. It should be RECIPIENTS.
putIfNotNull(customAttributes, AUDIENCES, requestedRecipient);
|
…lopment iteration
…branch Fix role association check
…lopment iteration
…ts-sign-and-signature-validation Add util methods for signing and signature validation
…lopment iteration
…ts-sign-and-signature-validation Throw signature exception from signing and signature validation utils
…lopment iteration
Refactor ActionManagementAuditLogger
…lopment iteration
…iqueness-feature Add support for claim-wise uniqueness validation
…lopment iteration
Saml feature tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request