Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce role properties object to store role related properties #6194

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

ShanChathusanda93
Copy link
Contributor

@ShanChathusanda93 ShanChathusanda93 commented Dec 10, 2024

Proposed changes in this pull request

@ShanChathusanda93 ShanChathusanda93 force-pushed the role-prop-branch branch 4 times, most recently from 9459b46 to 64c6385 Compare December 11, 2024 03:38
@ShanChathusanda93 ShanChathusanda93 marked this pull request as ready for review December 11, 2024 03:38
@ShanChathusanda93 ShanChathusanda93 force-pushed the role-prop-branch branch 2 times, most recently from d352a76 to d440367 Compare December 11, 2024 04:03
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 45.45%. Comparing base (65ae6fe) to head (335a489).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...bon/identity/role/v2/mgt/core/dao/RoleDAOImpl.java 66.66% 4 Missing and 1 partial ⚠️
...2/carbon/identity/role/v2/mgt/core/model/Role.java 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6194      +/-   ##
============================================
+ Coverage     44.94%   45.45%   +0.51%     
- Complexity    13898    14003     +105     
============================================
  Files          1620     1616       -4     
  Lines        100537   100408     -129     
  Branches      16963    16936      -27     
============================================
+ Hits          45185    45644     +459     
+ Misses        48641    48077     -564     
+ Partials       6711     6687      -24     
Flag Coverage Δ
unit 27.94% <75.00%> (+1.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShanChathusanda93 ShanChathusanda93 force-pushed the role-prop-branch branch 8 times, most recently from 55515c6 to 24b1ea8 Compare December 14, 2024 10:38
AnuradhaSK
AnuradhaSK previously approved these changes Dec 16, 2024
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12348876229

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12348876229
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12348876229

@ShanChathusanda93 ShanChathusanda93 merged commit db2d2a8 into wso2:master Dec 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for creating OAuth 2.0 clients inside B2B organizations for B2B API access
3 participants