Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce persistence layer to store SAML configurations #6238

Closed
wants to merge 4 commits into from

Conversation

Osara-B
Copy link
Contributor

@Osara-B Osara-B commented Dec 20, 2024

Proposed changes in this pull request

$subject as the initial implementation to decouple storage type from the configuration management.

  • SAMLSSOServiceProviderDAO interface acts as the storage independent interface to handle SAML configurations
  • SAMLSSOServiceProviderRegistryDAOImpl acts as the registry implementation of the above interface

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12425835334

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 62.77533% with 169 lines in your changes missing coverage. Please review.

Project coverage is 45.61%. Comparing base (9dbc3dd) to head (35e06e5).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...ore/dao/SAMLSSOServiceProviderRegistryDAOImpl.java 65.97% 103 Missing and 44 partials ⚠️
...y/core/persistence/IdentityPersistenceManager.java 0.00% 14 Missing ⚠️
...n/identity/core/SAMLSSOServiceProviderManager.java 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6238      +/-   ##
============================================
- Coverage     45.67%   45.61%   -0.06%     
- Complexity    14056    14058       +2     
============================================
  Files          1632     1631       -1     
  Lines        100532   101479     +947     
  Branches      17629    17913     +284     
============================================
+ Hits          45918    46292     +374     
- Misses        47925    48486     +561     
- Partials       6689     6701      +12     
Flag Coverage Δ
unit 28.31% <62.77%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12425835334
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12425835334

@Osara-B Osara-B closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants