Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce SAMLSSOPersistenceManagerFactory to switch between different persistence implementation #6240

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

Osara-B
Copy link
Contributor

@Osara-B Osara-B commented Dec 20, 2024

Proposed changes in this pull request

$subject. Related to,

@Osara-B Osara-B force-pushed the saml-removal branch 2 times, most recently from dd68425 to d7d8318 Compare December 20, 2024 09:16
@darshanasbg darshanasbg changed the title Introduce JDBC SAMLSSOServiceProviderDAO and Factory class implementation Introduce Persistence Manager Factory to switch between different persistence implementation Dec 20, 2024
@darshanasbg darshanasbg changed the title Introduce Persistence Manager Factory to switch between different persistence implementation Introduce SAMLSSOPersistenceManagerFactory to switch between different persistence implementation Dec 20, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12429281032

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 45.71%. Comparing base (44b8576) to head (7c68916).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
...y/core/persistence/IdentityPersistenceManager.java 0.00% 3 Missing ⚠️
...n/identity/core/SAMLSSOServiceProviderManager.java 0.00% 2 Missing ⚠️
.../SAMLServiceProviderPersistenceManagerFactory.java 84.61% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6240      +/-   ##
============================================
+ Coverage     45.66%   45.71%   +0.04%     
- Complexity    14080    14091      +11     
============================================
  Files          1632     1633       +1     
  Lines        100764   100857      +93     
  Branches      17705    17723      +18     
============================================
+ Hits          46016    46104      +88     
+ Misses        48036    48035       -1     
- Partials       6712     6718       +6     
Flag Coverage Δ
unit 28.40% <65.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12429281032
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12431396705

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12431396705
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12431396705

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12431396705
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12431396705

@darshanasbg darshanasbg merged commit f7352ad into wso2:master Dec 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants