Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spring Cleanup] Remove Spring dependencies in the secret management API #710

Open
wants to merge 2 commits into
base: feature-spring-cleanup
Choose a base branch
from
Open

[Spring Cleanup] Remove Spring dependencies in the secret management API #710

wants to merge 2 commits into from

Conversation

NipuniBhagya
Copy link
Contributor

Purpose

This PR removes dependencies and usages of the Spring framework in the secret management REST API.

Related Issue(s)

nilasini
nilasini reviewed Dec 12, 2024
View reviewed changes
...n/identity/api/server/secret/management/v1/factories/SecretTypeManagementServiceFactory.java
private static final SecretTypeManagementService SERVICE;

static {
SecretManager secretManager = (SecretManager) PrivilegedCarbonContext.getThreadLocalCarbonContext()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not adding a data holder to get the osgi service?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilasini nilasini nilasini left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NipuniBhagya @nilasini