Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce B2B Resolving Capabilities to Email/SMS Template Mgt APIs #755

Merged
merged 7 commits into from
Dec 10, 2024

Conversation

dhaura
Copy link
Contributor

@dhaura dhaura commented Dec 5, 2024

Purpose

  • This PR modifies the following APIs and their endpoints with resolve query parameter, so that when resolve param is set to true, the endpoint will return the resolved notification template throughout its ancestor organization hierarchy.
    • Email Templates V2 API
      • GET /email/template-types/{template-type-id}/app-templates/{app-uuid}
      • GET /email/template-types/{template-type-id}/app-templates/{app-uuid}/{locale}
    • Notification Templates API
      • GET /notification/email/template-types/{template-type-id}/org-templates
      • GET /notification/email/template-types/{template-type-id}/org-templates/{locale}
      • GET /notification/email/template-types/{template-type-id}/app-templates/{app-uuid}
      • GET /notification/email/template-types/{template-type-id}/app-templates/{app-uuid}/{locale}
      • GET /notification/sms/template-types/{template-type-id}/org-templates
      • GET /notification/sms/template-types/{template-type-id}/org-templates/{locale}
      • GET /notification/sms/template-types/{template-type-id}/app-templates/{app-uuid}
      • GET /notification/sms/template-types/{template-type-id}/app-templates/{app-uuid}/{locale}
  • If the resolve param is set to false, or not set at all, it will return only the current organization's or application's template. Threrefore, if the template is not found it will return 404.

Related Issues

Related PRs

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@AnuradhaSK
Copy link
Contributor

Let's link the API doc impact issue and send the doc update PR as well

@dhaura
Copy link
Contributor Author

dhaura commented Dec 6, 2024

@dhaura
Copy link
Contributor Author

dhaura commented Dec 9, 2024

Integration Tests

@dhaura
Copy link
Contributor Author

dhaura commented Dec 10, 2024

The PR builder is expected to fail due to the issue outlined in wso2-extensions/identity-event-handler-notification#291 (comment). Despite this, proceeding to merge this PR and update both versions in product-is and run the PR builder against that PR.

@dhaura dhaura merged commit 3bafbe9 into wso2:master Dec 10, 2024
4 checks passed
@dhaura
Copy link
Contributor Author

dhaura commented Dec 10, 2024

PR builder is successful - wso2/product-is#21999 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants