Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve email domain discovery page to incorporate new configuration for enabling email domain discovery for self-registration #7084

Merged
merged 7 commits into from
Dec 4, 2024

Conversation

Yasasr1
Copy link
Contributor

@Yasasr1 Yasasr1 commented Nov 5, 2024

Purpose

Following improvements will be made to the existing email domain discovery page

  • Generalize the page name to "Organization Discovery"
  • Move down the assign email domain button from top right corner to separate email domain discovery related configs from email domain mappings for organizations
  • Improve the info message at the top to mention the flows that restricts email domains when email domain discovery is enabled
  • Add a checkbox to incorporate the new config: email domain based organization discovery for self-registration
Screenshot 2024-11-05 at 10 50 23 AM

Related issue

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.02%. Comparing base (ef0a800) to head (6ca0f80).
Report is 1072 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7084      +/-   ##
==========================================
+ Coverage   31.79%   32.02%   +0.22%     
==========================================
  Files          41       41              
  Lines         890      893       +3     
  Branches      220      220              
==========================================
+ Hits          283      286       +3     
- Misses        557      587      +30     
+ Partials       50       20      -30     
Flag Coverage Δ
@wso2is/core 32.02% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

@Yasasr1 Yasasr1 force-pushed the b2b-self-signup-config branch from 4fad846 to 9d66740 Compare November 6, 2024 03:35
@Yasasr1 Yasasr1 force-pushed the b2b-self-signup-config branch from adcb98a to 859fbcd Compare November 13, 2024 09:22
@Yasasr1 Yasasr1 force-pushed the b2b-self-signup-config branch from 859fbcd to ba5ced4 Compare November 13, 2024 09:23
pavinduLakshan
pavinduLakshan previously approved these changes Nov 18, 2024
@Yasasr1 Yasasr1 force-pushed the b2b-self-signup-config branch from 9b9e2f5 to 3b6f94a Compare December 2, 2024 06:16
@pavinduLakshan pavinduLakshan dismissed their stale review December 2, 2024 06:31

missing changeset for a changed package

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@Yasasr1 Yasasr1 merged commit 6118eea into wso2:master Dec 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants