Update the password length validation with Password max allowed length config. #7185
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7185 +/- ##
==========================================
+ Coverage 32.02% 32.32% +0.30%
==========================================
Files 41 42 +1
Lines 893 897 +4
Branches 204 221 +17
==========================================
+ Hits 286 290 +4
+ Misses 607 587 -20
- Partials 0 20 +20
Flags with carried forward coverage won't be shown. Click here to find out more. |
...nsole/java/org.wso2.identity.apps.console.server.feature/resources/deployment.config.json.j2
Outdated
Show resolved
Hide resolved
.changeset/spicy-bottles-obey.md
Outdated
| "@wso2is/core": minor | ||
| "@wso2is/i18n": minor |
There was a problem hiding this comment.
Since the changes to core and i18n are minor, let's add a separate changeset for those modules with patch version upgrade.
apps/myaccount/src/configs/app.ts
Outdated
| @@ -163,6 +163,7 @@ export class Config { | |||
| window["AppUtils"]?.getConfig()?.ui?.isMultipleEmailsAndMobileNumbersEnabled, | |||
| isPasswordInputValidationEnabled: window["AppUtils"]?.getConfig()?.ui?.isPasswordInputValidationEnabled, | |||
| isProfileUsernameReadonly: window["AppUtils"]?.getConfig()?.ui?.isProfileUsernameReadonly, | |||
| passwordPolicyConfigs: window[ "AppUtils" ]?.getConfig()?.ui?.passwordPolicyConfigs, | |||
There was a problem hiding this comment.
We don't use this value anywhere in myaccount, do we? if it's not used, better not to add it here.
| .VALIDATION_CONFIGURATION_FORM_FIELD_CONSTRAINTS | ||
| .PASSWORD_MAX_LENGTH | ||
| } | ||
| maxLength={ maxPasswordValueLength } |
There was a problem hiding this comment.
Will we need maxLength to be configured since the input is a number field?
| @@ -99,6 +99,9 @@ export const ValidationConfigEditPage: FunctionComponent<MyAccountSettingsEditPa | |||
| state?.config?.ui?.features?.loginAndRegistration?.disabledFeatures); | |||
| const isRuleBasedPasswordExpiryDisabled: boolean = disabledFeatures?.includes("ruleBasedPasswordExpiry"); | |||
| const featureConfig: FeatureConfigInterface = useSelector((state: AppState) => state?.config?.ui?.features); | |||
| const maxPasswordValue: number = useSelector((state: AppState) => | |||
There was a problem hiding this comment.
| const maxPasswordValue: number = useSelector((state: AppState) => | |
| const maxPasswordLength: number = useSelector((state: AppState) => |
There was a problem hiding this comment.
Fixed by 00a3218 and renamed according to the support PR suggestion from kayathri.
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
Malith-19
added
trigger-pr-builder
Purpose
With the introduction of new config for the password max allowed length, updated the validations with that config.
Related Issues
Related PRs
Checklist
Security checks