[bug-fix] Reposition internal notification sending feature
#7227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7227 +/- ##
=======================================
Coverage 32.32% 32.32%
=======================================
Files 42 42
Lines 897 897
Branches 216 204 -12
=======================================
Hits 290 290
- Misses 557 607 +50
+ Partials 50 0 -50
Flags with carried forward coverage won't be shown. Click here to find out more. |
JayaShakthi97
commented
Dec 19, 2024
Comment on lines
+126
to
+127
| // eslint-disable-next-line max-len | ||
| ServerConfigurationsConstants.EMAIL_VERIFICATION_NOTIFICATIONS_INTERNALLY_MANAGED, // Manage notifications sending internally |
There was a problem hiding this comment.
Can not fix the max-len warning by splitting into two lines.
JayaShakthi97
force-pushed
the
fix-21223
branch
from
1ccfef3 to
4957960
Compare
|
Conflicts are getting due to the releases. Will be resolved once ready to merge. |
...nsole/java/org.wso2.identity.apps.console.server.feature/resources/deployment.config.json.j2
Show resolved
Hide resolved
features/admin.server-configurations.v1/pages/connector-listing-page.tsx
Show resolved
Hide resolved
DonOmalVindula
previously approved these changes
Dec 20, 2024
JayaShakthi97
force-pushed
the
fix-21223
branch
from
b4d854d to
5a3e181
Compare
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
DonOmalVindula
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
internal notification sendingfeature intoLogin and Registrationsection.admin.server.v1feature.Related Issues
Internal Notification Sendingfeature product-is#21223Related PRs
Checklist
Security checks