-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dynamic topic modeling to clustering models #28
Conversation
cb3b2af
to
17878fe
Compare
This might be ready for a first review. Couple of notes when
Docs deployment is failing, but this is a separate issue #30. |
oh also there's a few redundant commits because I accidentally pushed some unrelated stuff, let me know if you'd rather have a cleaner PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pwetty nice. Couple of comments, but feel free to merge if you feel so inclined.
608557c
to
21944dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!! Feel free to merge.
fixes #11
Need to:
fit_transform_dynamic
toClusteringTopicModel
Still WIP and not tested, need to discuss what to do to compute temporal components when feature importance is based on distance from topic centroid, i.e.: