Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About /robot_description duplication #80

Open
mcres opened this issue Jul 9, 2024 · 1 comment
Open

About /robot_description duplication #80

mcres opened this issue Jul 9, 2024 · 1 comment

Comments

@mcres
Copy link

mcres commented Jul 9, 2024

This ticket is aimed to suggest a couple aspects that I think would improve building upon, debugging and maintaining this repository:

  1. The /robot_description topic should only be published by the /robot_state_publisher. This means that the move_group does not publish to it. When developing upon the repository, It can be very likely that both nodes have slightly different versions of such robot description, leading to difficult debugging sessions.
  2. Instead of generating multiple times a robot description and pass it as a parameter to e.g. the move_group or the controller_manager nodes, these could get such information from the /robot_description topic.

This would avoid the duplication of the /robot_description publishing and consumption and make sure that it is unique.

@penglongxiang
Copy link
Contributor

@mcres Thanks for your feedback, we will take a look at this issue later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants