Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GLM with design-based standard errors #304

Merged
merged 60 commits into from
Nov 23, 2023
Merged

Conversation

nadiaenh
Copy link
Collaborator

@nadiaenh nadiaenh commented Jun 3, 2023

Building on Ayush's code for GLM:

  • renamed glm( ) to svyglm( ) to avoid ambiguity and be consistent with R naming
  • changed variable names and added comment for clarity
  • added test for GLM's in bsrs
  • added documentation for GLM's
  • improved docstring
  • use Survey.variance( ) to calculate SE's after closing New data structures to support multiple replicate methods. #297

Ready to be merged as of August 24, 2023

@ayushpatnaikgit
Copy link
Member

ayushpatnaikgit commented Jun 3, 2023

  1. Add tests for other families also, such as logistic regression.
  2. Add documentation. Perhaps a tutorial in https://xkdr.github.io/Survey.jl/dev/getting_started/#Tutorial

Also, we may name it glm instead of svyglm. Just for now, we should avoid the ambiguity.

This PR solves issues #295

@ayushpatnaikgit ayushpatnaikgit changed the base branch from main to next_release June 3, 2023 09:41
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2023

Codecov Report

Merging #304 (c677962) into 0.3.1 (b5b9b09) will decrease coverage by 12.50%.
Report is 6 commits behind head on 0.3.1.
The diff coverage is 92.10%.

@@             Coverage Diff              @@
##             0.3.1     #304       +/-   ##
============================================
- Coverage   100.00%   87.50%   -12.50%     
============================================
  Files           14       15        +1     
  Lines          242      272       +30     
============================================
- Hits           242      238        -4     
- Misses           0       34       +34     
Files Changed Coverage Δ
src/Survey.jl 100.00% <ø> (ø)
src/quantile.jl 87.50% <57.14%> (-12.50%) ⬇️
src/ratio.jl 75.00% <70.00%> (-25.00%) ⬇️
src/bootstrap.jl 100.00% <100.00%> (ø)
src/by.jl 100.00% <100.00%> (ø)
src/jackknife.jl 100.00% <100.00%> (ø)
src/mean.jl 100.00% <100.00%> (ø)
src/reg.jl 100.00% <100.00%> (ø)
src/total.jl 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@nadiaenh nadiaenh changed the title WIP: Add GLM with design-based standard errors Add GLM with design-based standard errors Jun 19, 2023
@nadiaenh nadiaenh requested a review from ayushpatnaikgit June 19, 2023 17:53
@ayushpatnaikgit ayushpatnaikgit changed the base branch from next_release to 0.3.1 August 25, 2023 13:39
test/reg.jl Outdated Show resolved Hide resolved
src/ratio.jl Outdated Show resolved Hide resolved
src/bootstrap.jl Outdated Show resolved Hide resolved
src/jackknife.jl Outdated Show resolved Hide resolved
src/mean.jl Outdated Show resolved Hide resolved
@ayushpatnaikgit
Copy link
Member

  1. Can you try to change the name of the function to glm from svyglm?
  2. Can you add a doctest for glm?

@ayushpatnaikgit
Copy link
Member

Doctests were passing because :fix = true was uncommented in docs/project.toml this means that all doctests may have incorrect values.

@ayushpatnaikgit ayushpatnaikgit merged commit c425057 into xKDR:0.3.1 Nov 23, 2023
@ayushpatnaikgit
Copy link
Member

ayushpatnaikgit commented Dec 21, 2023

Bunch of doctests were failing. I am unsure why the doctest CI didn't give an error. I'll fix them in PR 314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants