[FOLLOWUP][PR514] Update to use the newer Kryo 5.6.0 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ilx
commented
Aug 9, 2024
ilx
commented
- Updated to use the newer Kryo5 shaded jar
- Initial change to use kryo5
- More kryo5 updates
- Removed chill-storm
- Two more classes that were missed
- A few more fixes
- Scala Fmt
- Reverting this change
- Test update
- Test result updated
- More test result updates
- Register all classes and fix the unit test issues
- All unit tests passed after rebase
- Scala version specific fixes
- Scala style fixes
- Use the latest kryo release: 5.5.0
- Switch to versionless kryo artifact
- Revert "Removed chill-storm"
- Switch to versionless kryo package in BlizzardKryoFactory
- Deleted the old comment in ScroogeThriftStructSerializer.scala
Registration is required by default in Kryo5: https://github.com/EsotericSoftware/kryo/wiki/Migration-to-v5#configuration-changes
This reverts commit 5c8310d.
mayur9991
reviewed
Aug 9, 2024
|
test |
Changed publishing method since we have to publish to private nexus repository
mayur9991
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.