Love 1588 #133
Open
Love 1588 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LOVE-1547 Added to answer config map hash
ommkar-xl
added
the
run-xl-up-pr
eltonkevani
suggested changes
May 26, 2020
There was a problem hiding this comment.
-deploy works
-undeploy works but it does not clean up all the created resources such as securitycontextconstraints.security.openshift.io xebialabs-privileged
-deploy again fails because resources already exist
All created resources by xl up should be deleted on undeploy. fix this on xl cli or put the correct metadata on the resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
User Story: https://xebialabs.atlassian.net/browse/LOVE-1588
Files Modified: xl-k8s-foundation, xl-release, xl-deploy
Files Added: Openshift-SCC, Test-Cases
Scope of The PR: This branch will be merged with Feature Branch LOVE-1459. After the feature is fully developed, it can be merged with Master Branch