viewType => type, as suggested by ATM (#743)

xh · Dec 5, 2024 · 6b00ad9 · 6b00ad9
1 parent 73b3356
commit 6b00ad9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/client-app/src/admin/tests/viewmanager/ViewManagerTestModel.ts b/client-app/src/admin/tests/viewmanager/ViewManagerTestModel.ts
@@ -75,7 +75,7 @@ export class ViewManagerTestModel extends HoistModel {
             .filter(it => it.isDirty)
             .map(it => it.name);
         return [
-            'viewType',
+            'type',
             'typeDisplayName',
             'globalDisplayName',
             'localStorageKey',
@@ -94,7 +94,7 @@ export class ViewManagerTestModel extends HoistModel {
 
         this.configFormModel = new FormModel({
             fields: [
-                {name: 'viewType', rules: [required], initialValue: 'testView'},
+                {name: 'type', rules: [required], initialValue: 'testView'},
                 {name: 'typeDisplayName', initialValue: 'view'},
                 {name: 'globalDisplayName', initialValue: 'global'},
                 {name: 'localStorageKey', initialValue: 'viewManagerTest'},
@@ -136,7 +136,7 @@ export class ViewManagerTestModel extends HoistModel {
 
         const data = configFormModel.getData(),
             {
-                viewType,
+                type,
                 typeDisplayName,
                 globalDisplayName,
                 localStorageKey,
@@ -154,7 +154,7 @@ export class ViewManagerTestModel extends HoistModel {
             : null;
 
         const newModel = await ViewManagerModel.createAsync({
-            viewType,
+            type,
             typeDisplayName,
             globalDisplayName,
             manageGlobal,

diff --git a/client-app/src/admin/tests/viewmanager/ViewManagerTestPanel.ts b/client-app/src/admin/tests/viewmanager/ViewManagerTestPanel.ts
@@ -135,7 +135,7 @@ const modelConfig = hoistCmp.factory({
             className: 'xh-pad tb-vm-test__model-conf',
             items: [
                 formField({
-                    field: 'viewType',
+                    field: 'type',
                     item: textInput()
                 }),
                 formField({

diff --git a/client-app/src/examples/portfolio/AppModel.ts b/client-app/src/examples/portfolio/AppModel.ts
@@ -18,7 +18,7 @@ export class AppModel extends BaseAppModel {
         // saved views are loaded and the desired option has been preselected before the model
         // is used to construct component-level models within PortfolioModel.
         this.portfolioViewManager = await ViewManagerModel.createAsync({
-            viewType: 'portfolioLayout',
+            type: 'portfolioLayout',
             typeDisplayName: 'Layout',
             enableDefault: true,
             manageGlobal: true,