Support for Testing ViewManager Revert Button (#738)

xh · Nov 19, 2024 · 90ddc3c · 90ddc3c
1 parent bc993a1
commit 90ddc3c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/client-app/src/admin/tests/viewmanager/ViewManagerTestModel.ts b/client-app/src/admin/tests/viewmanager/ViewManagerTestModel.ts
@@ -99,6 +99,7 @@ export class ViewManagerTestModel extends HoistModel {
                 {name: 'enableAutoSave', displayName: 'AutoSave', initialValue: true},
                 {name: 'enableFavorites', displayName: 'Faves', initialValue: true},
                 {name: 'showSaveButton', initialValue: 'whenDirty'},
+                {name: 'showRevertButton', initialValue: 'never'},
                 {
                     name: 'showPrivateViewsInSubMenu',
                     displayName: 'Show private views in sub-menu',

diff --git a/client-app/src/admin/tests/viewmanager/ViewManagerTestPanel.ts b/client-app/src/admin/tests/viewmanager/ViewManagerTestPanel.ts
@@ -100,6 +100,13 @@ const modelConFigForm = hoistCmp.factory<ViewManagerTestModel>({
                                 enableFilter: false
                             })
                         }),
+                        formField({
+                            field: 'showRevertButton',
+                            item: select({
+                                options: ['always', 'never', 'whenDirty'],
+                                enableFilter: false
+                            })
+                        }),
                         hbox(
                             formField({
                                 field: 'showPrivateViewsInSubMenu',
@@ -175,6 +182,7 @@ const persistablesPanel = hoistCmp.factory<ViewManagerTestModel>({
 
         const {
                 showSaveButton,
+                showRevertButton,
                 showPrivateViewsInSubMenu,
                 showSharedViewsInSubMenu,
                 customMenuButtonProps
@@ -190,6 +198,7 @@ const persistablesPanel = hoistCmp.factory<ViewManagerTestModel>({
             tbar: [
                 viewManager({
                     showSaveButton,
+                    showRevertButton,
                     showPrivateViewsInSubMenu,
                     showSharedViewsInSubMenu,
                     menuButtonProps
@@ -293,6 +302,7 @@ const persistablesPanel = hoistCmp.factory<ViewManagerTestModel>({
 const persistedComp = hoistCmp.factory({
     model: uses(ViewManagerTestModel),
     render({title, icon, persistPath, children, model, minHeight}) {
+        if (!persistPath) return null;
         const {value, pendingValue} = model.viewManagerModel,
             compVal = get(value, persistPath),
             compPendingVal = get(pendingValue, persistPath),