handle BUILD_STATIC_LIBS in FORTRAN #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. avoids installing static libs when they have been explicitly disabled doesn't handle BUILD_SHARED_LIBS, which is still assumed
minrk
force-pushed
the
fortran-static
branch
from
72f7941 to
218e708
Compare
minrk
changed the title
|
I only added handling of BUILD_STATIC_LIBS, leaving BUILD_SHARED_LIBS assumed True. I can add handling of both if you prefer. It appears that BUILD_STATIC_LIBS is subordinate to BUILD_SHARED_LIBS, so it is not allowed to build static without shared. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. to avoid installing static libs when they have been explicitly disabled
I'm not sure if you'd rather organize this differently so there are fewer conditionals, but this was the way to make the smallest diff since it's only
ifsand indentation changes, no reorganization.