Eliminate creationof superlu_dist_config.h in the source directory. … #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot needed and makes the source directory look like something needs to be added.
|
I need this in original SRC/. |
|
Since a cmake user needs it in only the build, won't that work?
How does that affect the make.inc user? They generate where they
want to, no?
…On 1/21/18 12:35 PM, X. Sherry Li wrote:
I need this in original SRC/.
I am supporting both CMake build and legacy "make.inc" user-editing
style (still a lot of users prefer the later.) That means, users can
go to original EXAMPLE/, compile and run the examples without
bothering cmake. In this case, need to include SRC/*.h files.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABX9TN57Mb5OMeDBQb8nRg79SvQliX3jks5tM5GPgaJpZM4Rl7ld>.
|
|
Even with cmake, I use make.inc.in template to generate a make.inc, so that
the users can use this to play with the source files in EXAMPLE/, and use
these flags in their apps. Users cannot easily work with the examples in
the build tree.
…On Sun, Jan 21, 2018 at 11:44 AM, jrobcary ***@***.***> wrote:
Since a cmake user needs it in only the build, won't that work?
How does that affect the make.inc user? They generate where they
want to, no?
On 1/21/18 12:35 PM, X. Sherry Li wrote:
>
> I need this in original SRC/.
> I am supporting both CMake build and legacy "make.inc" user-editing
> style (still a lot of users prefer the later.) That means, users can
> go to original EXAMPLE/, compile and run the examples without
> bothering cmake. In this case, need to include SRC/*.h files.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#22 (comment)
>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
ABX9TN57Mb5OMeDBQb8nRg79SvQliX3jks5tM5GPgaJpZM4Rl7ld>.
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALMq99E0pVDKU3YOItbqOKWQvq7rq1Trks5tM5OugaJpZM4Rl7ld>
.
|
|
Not sure I understand, but no problem. I can certainly live without
this change!
…On 1/21/18 12:54 PM, X. Sherry Li wrote:
Even with cmake, I use make.inc.in template to generate a make.inc, so
that
the users can use this to play with the source files in EXAMPLE/, and use
these flags in their apps. Users cannot easily work with the examples in
the build tree.
On Sun, Jan 21, 2018 at 11:44 AM, jrobcary ***@***.***>
wrote:
> Since a cmake user needs it in only the build, won't that work?
>
> How does that affect the make.inc user? They generate where they
> want to, no?
>
> On 1/21/18 12:35 PM, X. Sherry Li wrote:
> >
> > I need this in original SRC/.
> > I am supporting both CMake build and legacy "make.inc" user-editing
> > style (still a lot of users prefer the later.) That means, users can
> > go to original EXAMPLE/, compile and run the examples without
> > bothering cmake. In this case, need to include SRC/*.h files.
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> >
<#22 (comment)
> >,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/
> ABX9TN57Mb5OMeDBQb8nRg79SvQliX3jks5tM5GPgaJpZM4Rl7ld>.
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
>
<#22 (comment)>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/ALMq99E0pVDKU3YOItbqOKWQvq7rq1Trks5tM5OugaJpZM4Rl7ld>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABX9TDN5oGm5Zwj5Qqqmgt0-n7zg_VDcks5tM5YIgaJpZM4Rl7ld>.
|
|
The EXAMPLE/ in build tree only have executables, so users cannot change it
to match their apps need.
For convenience, I am still expose make.inc (cmake generated from
make.inc.in) to the users, which contains the flags used while building.
Users can take this info and the code in source tree to merge in their apps.
Do you have better ideas how to make this easy for the users?
…On Sun, Jan 21, 2018 at 11:56 AM, jrobcary ***@***.***> wrote:
Not sure I understand, but no problem. I can certainly live without
this change!
On 1/21/18 12:54 PM, X. Sherry Li wrote:
> Even with cmake, I use make.inc.in template to generate a make.inc, so
> that
> the users can use this to play with the source files in EXAMPLE/, and use
> these flags in their apps. Users cannot easily work with the examples in
> the build tree.
>
> On Sun, Jan 21, 2018 at 11:44 AM, jrobcary ***@***.***>
> wrote:
>
> > Since a cmake user needs it in only the build, won't that work?
> >
> > How does that affect the make.inc user? They generate where they
> > want to, no?
> >
> > On 1/21/18 12:35 PM, X. Sherry Li wrote:
> > >
> > > I need this in original SRC/.
> > > I am supporting both CMake build and legacy "make.inc" user-editing
> > > style (still a lot of users prefer the later.) That means, users can
> > > go to original EXAMPLE/, compile and run the examples without
> > > bothering cmake. In this case, need to include SRC/*.h files.
> > >
> > > —
> > > You are receiving this because you authored the thread.
> > > Reply to this email directly, view it on GitHub
> > >
> <#22 (comment)
> > >,
> > > or mute the thread
> > > <https://github.com/notifications/unsubscribe-auth/
> > ABX9TN57Mb5OMeDBQb8nRg79SvQliX3jks5tM5GPgaJpZM4Rl7ld>.
> > >
> >
> > —
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> >
> <#22 (comment)
>,
> > or mute the thread
> >
> <https://github.com/notifications/unsubscribe-auth/
ALMq99E0pVDKU3YOItbqOKWQvq7rq1Trks5tM5OugaJpZM4Rl7ld>
> > .
> >
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#22 (comment)
>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-
auth/ABX9TDN5oGm5Zwj5Qqqmgt0-n7zg_VDcks5tM5YIgaJpZM4Rl7ld>.
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALMq90xZ4QDTToASRP52dSTBZ6oCV2bHks5tM5aGgaJpZM4Rl7ld>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Not needed and makes the source directory look like something needs to be added.