XWIKI-21597: Make the rights UI use icon themes #2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated tests: ** EditRightsPane used a custom class to hold the state of the icon. Replaced the reliance on the icon URL with the class on the button. Renamed everything in this class to let go off the icon, which is just a style thing and should not be based upon for such logic. ** Changed the GlobbalRightsAdministrationSectionPage object to fit the new attributes used on the checkbox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21597
Changes
Description
Screenshots & Video
None, test only modifications.
Executed Tests
This PR solves two sets of regressions seen on CI:
mvn clean install -f xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-pageobjects; mvn clean install -f xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker -Pdocker,integration-tests -Dit.test=LoginIT, related to regression https://ci.xwiki.org/job/XWiki/job/xwiki-platform/job/master/7167/testReport/org.xwiki.flamingo.test.docker/AllIT$NestedLoginIT/Platform_Builds___main___integration_tests___IT_for_xwiki_platform_core_xwiki_platform_flamingo_xwiki_platform_flamingo_skin_xwiki_platform_flamingo_skin_test_xwiki_platform_flamingo_skin_test_docker___Build_for_IT_for_xwiki_platform_core_xwiki_platform_flamingo_xwiki_platform_flamingo_skin_xwiki_platform_flamingo_skin_test_xwiki_platform_flamingo_skin_test_docker___redirectBackAfterLogin_TestUtils__XWikiWebDriver__TestReference_/mvn clean install -f xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui; mvn clean install -f xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-docker -Dit.test=UsersGroupsRightsManagementIT -Pdocker, related to regression https://ci.xwiki.org/job/XWiki/job/xwiki-platform/job/master/7167/testReport/org.xwiki.administration.test.ui/AllIT$NestedUsersGroupsRightsManagementIT/Platform_Builds___main___integration_tests___IT_for_xwiki_platform_core_xwiki_platform_administration_xwiki_platform_administration_test_xwiki_platform_administration_test_docker___Build_for_IT_for_xwiki_platform_core_xwiki_platform_administration_xwiki_platform_administration_test_xwiki_platform_administration_test_docker___createAndDeleteGroup_TestUtils__TestReference_/mvn clean install -f xwiki-platform-core/xwiki-platform-index/xwiki-platform-index-test/xwiki-platform-index-test-docker -Pdocker -Dit.test=NestedAllDocsITsuccessfully passed, related to regression https://ci.xwiki.org/job/XWiki/job/xwiki-platform/job/master/7167/testReport/org.xwiki.index.test.ui.docker/AllIT$NestedAllDocsIT/Platform_Builds___main___integration_tests___IT_for_xwiki_platform_core_xwiki_platform_index_xwiki_platform_index_test_xwiki_platform_index_test_docker___Build_for_IT_for_xwiki_platform_core_xwiki_platform_index_xwiki_platform_index_test_xwiki_platform_index_test_docker___verifyAllDocs_TestUtils__TestInfo__TestReference_/Expected merging strategy