XWIKI-21922: Introduce methods to fetch a subset of revisions in XWikiVersioningStoreInterface #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iVersioningStoreInterface * Fix missing support for "ALL" ranges
…iVersioningStoreInterface * Fix XWikiDocumentArchive caching issues
manuelleduc
reviewed
Mar 7, 2024
...-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/criteria/impl/RevisionCriteria.java
Show resolved
Hide resolved
surli
added
the
backport stable-15.10.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21922
Changes
Description
Clarifications
In the previous PR (#2925) I missed a case with ranges: when the size is 0, every revision should be included. This lead to several tests failing in the CI, but it is now working properly.
Also, when investigating this, I noticed I overlooked some caching operations done on document archives which were incompatible with the implementation of the new API. Partial archives could be stored and reused later, possibly ignoring criteria. A fix for that is also provided, but this one will impact performances until #2926 and #2927 are also merged.
Screenshots & Video
N/A
Executed Tests
Previously failing tests were successfully run with these patches.
Expected merging strategy