-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XWIKI-13858: Inconsistency between Long Text and Content fields display in AWM wizard and entries #3594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay in AWM wizard and entries * In all places where we can edit this object, we follow the userPreference regarding text editors.
Sereza7
added
backport stable-15.10.x
Used for automatic backport to 15.10.x branch.
backport stable-16.4.x
labels
Oct 24, 2024
Sereza7
removed
the
backport stable-15.10.x
Used for automatic backport to 15.10.x branch.
label
Oct 31, 2024
mflorea
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments should be deleted / moved along with the related code.
...inminutes/xwiki-platform-appwithinminutes-ui/src/main/resources/AppWithinMinutes/Content.xml
Outdated
Show resolved
Hide resolved
...inminutes/xwiki-platform-appwithinminutes-ui/src/main/resources/AppWithinMinutes/Content.xml
Outdated
Show resolved
Hide resolved
…ay in AWM wizard and entries * Updated comments
The comments have been reviewed and the PR is ready for further reviewing or a merge. Thank you for the review MFlorea! |
mflorea
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-13858
Changes
Description
Clarifications
Screenshots & Video
Screenshots only for the class editor. On the ticket there's already screenshots showing that the issue has been solved for the entry editor.
Before the PR
With prefered editor = text
With prefered editor = Wysiwyg
After the PR
With prefered editor = text
With prefered editor = Wysiwyg
Executed Tests
Manual tests (see above).
There was no test change when merging e6b6769 ,which is partly what we revert.
Expected merging strategy