XWIKI-22675: Extra line below facet items #3759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed the extra line
github-actions bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
(cherry picked from commit 2f1ee0f)
manuelleduc
pushed a commit
that referenced
this pull request
Dec 13, 2024
(cherry picked from commit 2f1ee0f) Co-authored-by: LucasC <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22675
Changes
Description
Clarifications
:afterpseudo element. It was its only purpose, we can remove this pseudo element without any side effect on the layout.Screenshots & Video
Before the changes proposed in this PR:
After the changes proposed in this PR:
We can see that the lines are removed, and the layout is substantially the same. Note that these screenshots have been made on an instance where change for XWIKI-22674 were already made, it's slightly different from the default today. However, the difference between the before and after screenshots highlights that the changes proposed here have the expected effect.
Executed Tests
Manual test only. See screenshots above. The affected UI was just a pseudo element, so I highly doubt it was tested at any point. This is a style change only so it makes it pretty safe nevertheless.
Expected merging strategy