Solved defaults changing *existing games* due to no serialization of …

…defaults in json. (#12049) Only new installations get rectangular and world wrap by default
yairm210 · Aug 1, 2024 · 9f0abbd · 9f0abbd
1 parent efb2118
commit 9f0abbd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/core/src/com/unciv/logic/civilization/Civilization.kt b/core/src/com/unciv/logic/civilization/Civilization.kt
@@ -58,7 +58,6 @@ import com.unciv.models.stats.Stats
 import com.unciv.models.translations.tr
 import com.unciv.ui.components.extensions.toPercent
 import com.unciv.ui.screens.victoryscreen.RankingType
-import com.unciv.utils.Log
 import org.jetbrains.annotations.VisibleForTesting
 import kotlin.math.max
 import kotlin.math.min
@@ -561,6 +560,7 @@ class Civilization : IsPartOfGameInfoSerialization {
     }.toList() // Triggers can e.g. add buildings which contain triggers, causing concurrent modification errors
 
 
+    @Transient
     private val cachedMatchesFilterResult = HashMap<String, Boolean>()
 
     /** Implements [UniqueParameterType.CivFilter][com.unciv.models.ruleset.unique.UniqueParameterType.CivFilter] */

diff --git a/core/src/com/unciv/logic/map/MapParameters.kt b/core/src/com/unciv/logic/map/MapParameters.kt
@@ -41,12 +41,12 @@ object MapType {
 class MapParameters : IsPartOfGameInfoSerialization {
     var name = ""
     var type = MapType.pangaea
-    var shape = MapShape.rectangular
+    var shape = MapShape.hexagonal
     var mapSize = MapSize.Medium
     var mapResources = MapResourceSetting.default.label
     var noRuins = false
     var noNaturalWonders = false
-    var worldWrap = true
+    var worldWrap = false
     var strategicBalance = false
     var legendaryStart = false
 

diff --git a/core/src/com/unciv/models/metadata/GameSetupInfo.kt b/core/src/com/unciv/models/metadata/GameSetupInfo.kt
@@ -4,6 +4,7 @@ import com.badlogic.gdx.files.FileHandle
 import com.unciv.UncivGame
 import com.unciv.logic.GameInfo
 import com.unciv.logic.map.MapParameters
+import com.unciv.logic.map.MapShape
 
 class GameSetupInfo(
     val gameParameters: GameParameters = GameParameters(),
@@ -26,6 +27,8 @@ class GameSetupInfo(
         fun fromSettings(defaultDifficulty: String? = null) = UncivGame.Current.settings.run {
             if (lastGameSetup == null) GameSetupInfo().apply {
                 if (defaultDifficulty != null) gameParameters.difficulty = defaultDifficulty
+                mapParameters.shape = MapShape.rectangular
+                mapParameters.worldWrap = true
             }
             else GameSetupInfo(lastGameSetup!!).apply {
                 mapParameters.reseed()