Rebalance Food Weights

[itanasi]

Rework the weight of Food evaluation for Citizen Management.
Generic AI Civ performance improves and this matches closer to human expectations. Some AIs such as Korea will perform a bit worse in certain scenarios due to Personalities, but we should fix the Personalities instead of break base behavior.
Still room for improvements in corner cases.
Discussion and data in Discord thread:
https://discord.com/channels/586194543280390151/1306726293102006453/1306726299884195932

Also adding a small feature to the console sims

[itanasi]

Then I'd argue you're mixing issues. Personalities messing with things is separate and we should work to have a solid base value. Can you set up a baseline game of generic Civs and see how they behave instead?

Fundamentally, do you feel strongly enough that you want to veto this PR? Or can we pull this and work on other improvements later?

[EmperorPinguin]

Then I'd argue you're mixing issues. Personalities messing with things is separate and we should work to have a solid base value. Can you set up a baseline game of generic Civs and see how they behave instead?

With these values I ran 5 games (20 data points) from the same t0 save I mentioned before (with personalities), and got an average t80 pop of 93.7. The last 'benchmark' was 99.9 t80 pop #12582 (comment). That was on a different version of Unciv, but is was a gain compared to 94.7 t80 pop ceteris paribus. In a test before that, I got 95.8 t80 pop. While 5 games isn't statistically significant, all these are higher than 93.7 which makes me suspicious, and my other experiments of lowering food value multiplier also resulted in lower population.

Note that somewhat lowering food value itself doesn't logically lead to lower pop, as there should be more production available to construct growth infrastructure (settlers, workers, granaries, water mills, aqueducts etc).

How generic civs behave should follow from the values you set, so (2× food value) > (2 production) > (1.5 × food value) > (1 production + 1 gold) > (1× food value) > (1 production). I'll see if I can set up a test with generic civs tomorrow, maybe we should automate this to get statistically significant results.