Allow stat from battle uniques to also give stockpiles #12689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairm210
requested changes
Dec 22, 2024
| civ.addGameResource(resource, plunderedAmount) | ||
| val icon = if (resource is SubStat) resource.icon else "ResourceIcons/$resourceName" | ||
| civ.addNotification( | ||
| "Your [${plunderingUnit.getName()}] plundered [${plunderedAmount}] [${resourceName}] from [${plunderedUnit.getName()}]", |
There was a problem hiding this comment.
Do we not notify for stat plundering?
There was a problem hiding this comment.
Notification is a bit lower (line 404). This is actually copy paste from there
Comment on lines
379
to
382
| val resource = Stat.safeValueOf(resourceName) ?: | ||
| SubStat.safeValueOf(resourceName) ?: | ||
| plunderedUnit.getCivInfo().gameInfo.ruleset.tileResources[resourceName] | ||
| if (resource == null) continue |
There was a problem hiding this comment.
Add empty lines before and after this segment
yairm210
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add some helpers to GameResource and SubStat to make it easier to work with