Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend civilopedia texts. #12701

Closed
wants to merge 1 commit into from

Conversation

J0anJosep
Copy link
Contributor

Two sentences missed the full stop at the end.
I think I amended the right file, but not sure.

@SomeTroglodyte
Copy link
Collaborator

amended the right file

Right file, but it is also the "original" that will need translation, and with this you're changing the lookup key.

(meaning the translations would no longer be found because the key is not identical, and the release cycle running the translation generator would delete them as it no longer sees the old key, adding the new key with a "translation required")

This would be one of the rare cases where fixing every single translation fine could be worth it - changing the "lookup key" English on the LEFT side to match the new original - and mostly leaving the right side alone unless it obviously needs the same punctuation change and you're sure you know that language uses Latin punctuation.

@yairm210
Copy link
Owner

Done manually across all files

@yairm210 yairm210 closed this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants