ch-moniroting s3-credentials-config: return crit on unexpected error #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Burmak
commented
Dec 18, 2024
Comment on lines
+31
to
+75
| try: | ||
| if not present: | ||
| if not os.path.exists(CLICKHOUSE_S3_CREDENTIALS_CONFIG_PATH): | ||
| return Result(OK) | ||
| return Result(CRIT, "S3 default config present, but shouldn't") | ||
|
|
||
| if os.path.isfile(CLICKHOUSE_RESETUP_CONFIG_PATH): | ||
| return Result(OK, "Skipped as resetup is in progress") | ||
| if os.path.isfile(CLICKHOUSE_RESETUP_CONFIG_PATH): | ||
| return Result(OK, "Skipped as resetup is in progress") | ||
|
|
||
| if os.path.exists(CLICKHOUSE_S3_CREDENTIALS_CONFIG_PATH): | ||
| delta = timedelta( | ||
| seconds=time.time() | ||
| - os.path.getmtime(CLICKHOUSE_S3_CREDENTIALS_CONFIG_PATH) | ||
| ) | ||
| if delta < timedelta(hours=2): | ||
| return Result(OK) | ||
| if delta < timedelta(hours=4): | ||
| return Result( | ||
| WARNING, | ||
| f"S3 token expire in {_delta_to_hours(timedelta(hours=12) - delta)} hours", | ||
| if os.path.exists(CLICKHOUSE_S3_CREDENTIALS_CONFIG_PATH): | ||
| delta = timedelta( | ||
| seconds=time.time() | ||
| - os.path.getmtime(CLICKHOUSE_S3_CREDENTIALS_CONFIG_PATH) | ||
| ) | ||
| if delta < timedelta(hours=2): | ||
| return Result(OK) | ||
| if delta < timedelta(hours=4): | ||
| return Result( | ||
| WARNING, | ||
| f"S3 token expire in {_delta_to_hours(timedelta(hours=12) - delta)} hours", | ||
| ) | ||
|
|
||
| if delta < timedelta(hours=12): | ||
| msg = f"S3 token expire in {_delta_to_hours(timedelta(hours=12) - delta)} hours" | ||
| if delta < timedelta(hours=12): | ||
| msg = f"S3 token expire in {_delta_to_hours(timedelta(hours=12) - delta)} hours" | ||
| else: | ||
| msg = f"S3 token expired {_delta_to_hours(delta - timedelta(hours=12))} hours ago" | ||
| else: | ||
| msg = f"S3 token expired {_delta_to_hours(delta - timedelta(hours=12))} hours ago" | ||
| else: | ||
| msg = "S3 default config not present" | ||
| msg = "S3 default config not present" | ||
|
|
||
| code = _request_token(ctx.obj["s3_cred_metadata_addr"]).status_code | ||
| if code == 404: | ||
| if "default" in requests.get( | ||
| f"http://{ctx.obj['s3_cred_metadata_addr']}/computeMetadata/v1/instance/?recursive=true", | ||
| headers={"Metadata-Flavor": "Google"}, | ||
| timeout=60, | ||
| ).json().get("serviceAccounts", {}): | ||
| return Result(WARNING, "service account deleted") | ||
| code = _request_token(ctx.obj["s3_cred_metadata_addr"]).status_code | ||
| if code == 404: | ||
| if "default" in requests.get( | ||
| f"http://{ctx.obj['s3_cred_metadata_addr']}/computeMetadata/v1/instance/?recursive=true", | ||
| headers={"Metadata-Flavor": "Google"}, | ||
| timeout=60, | ||
| ).json().get("serviceAccounts", {}): | ||
| return Result(WARNING, "service account deleted") | ||
|
|
||
| return Result(CRIT, "service account not linked") | ||
| return Result(CRIT, "service account not linked") | ||
|
|
||
| return Result(CRIT, f"{msg}, iam code {code}") | ||
| return Result(CRIT, f"{msg}, iam code {code}") | ||
|
|
||
| except Exception as e: | ||
| logging.exception("Failed to check S3 credentials config") | ||
| return Result(CRIT, str(e)) |
There was a problem hiding this comment.
Just added global try-catch.
NikitaUnisikhin
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.