Improved monitoring of replica state during large binlog load #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Some reveiw of old unit tests
- removed 2 warnings
teem0n
approved these changes
Dec 23, 2024
noname0443
approved these changes
Dec 23, 2024
noname0443
approved these changes
Dec 23, 2024
|
I believe it is a good idea to aggregate tests into two scripts, because it reduces consuming resources on creating a container on each test, but I suppose we may have a problem in the future with flapped tests. If one is dead due to context deadline, we have to restart a whole test set for either 5.7 or 8.0. I think we should separate CI/CD changes in a separate PR and maybe add some restart logic for flapped tests. |
|
Yes, I think you are right, we should split the PR. I want to add my thoughts on this. |
|
BTW: In the current view, we launch tests in a sequence. So it can be a good idea to launch them in a parallel way. |
noname0443
approved these changes
Dec 24, 2024
noname0443
approved these changes
Dec 24, 2024
noname0443
reviewed
Dec 24, 2024
noname0443
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved monitoring of replica state during large binlog load
Description:
This pull request addresses an issue where the ZooKeeper service mistakenly believed that a replica was dead when it was actually downloading a large binlog file.
To resolve this problem, I added a new field to the replica — NodeState.IsBinlogLoading. This field will allow us to more accurately track the state of the replica and ensure that the service correctly identifies when a replica is in the process of downloading a binlog.
Additionally, I have written unit tests and integration tests that cover the new functionality I have added.
Small fixes
I have also made minor updates to the existing code in the unit tests to improve the readability of the tests.
Finally, I have updated the Dockerfile to reflect the changes made in this pull request. This update removes two warnings and ensures that the latest version of the code is being used in the container.