add new boolean GH_COMMENT env var for whether to post GitHub comments #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is useful because we just use Shamer as a leaderboard that aggregates coverage contributions by user. we use Coveralls to collect and track coverage over time, which is great, so we don't need Shamer for that. setting this new env var to false lets us skip the GitHub comments, since Coveralls is already a status check on our GitHub PRs, and also lets us avoid storing coverage data in AWS at all.
|
thanks again for merging the first PR. friendly ping on the rest! |
| except: | ||
| s3 = None | ||
| s3 = None | ||
| if constants.get('GH_COMMENT').lower() == 'true': |
There was a problem hiding this comment.
You don't actually need any of the changes in this file, because connecting to S3 will fail if the constants are not set. Then later on we can keep the old if not s3. This de-couples S3 usage from commenting, in case we want it for something else later.
There was a problem hiding this comment.
ok! makes sense. the one reason i tied them together was to avoid the red 'Your S3 keys are invalid!' error message, since we intentionally aren't using S3. should i add another constant for that? open to other ideas!
|
@snarfed thanks again for the contributions! left comments on all 3 remaining PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is useful because we just use Shamer as a leaderboard that aggregates coverage contributions by user. we use Coveralls to collect and track coverage over time, which is great, so we don't need Shamer for that. setting this new env var to false lets us skip the GitHub comments, since Coveralls is already a status check on our GitHub PRs, and also lets us avoid storing coverage data in AWS at all.