fix https://github.com/yegor256/takes/issues/945 #1370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kartofanych
force-pushed
the
move_rq_base_method
branch
2 times, most recently
from
f047e75 to
a47374f
Compare
Kartofanych
force-pushed
the
move_rq_base_method
branch
from
a47374f to
6c2dae7
Compare
|
@yegor256 check please |
|
@Kartofanych what is the motivation for this? What problem are you trying to fix with these changes? |
this is fix of issue #945 |
|
@yegor256 Any updates on this? (course is already finished) |
|
@Kartofanych the issue #945 was just a proposal, not an accepted bug (I closed it now). Please, look at the issues that are labeled as "bug" only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move PqBaseMethod outside of parent interface
fix #945