Menu widget active with Closure #19060

[atrandafir]

Menu parent active status gets broken for the rest of the items when using Closure for one item #19060

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌
Fixed issues	#19060

[yii-bot]

Thank you for putting effort in the improvement of the Yii framework.
We have reviewed your pull request.

In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests.

Could you add these please?

Thanks!

P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests

This is an automated comment, triggered by adding the label pr:request for unit tests.

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e029988) 48.95% compared to head (f034274) 48.98%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #19061      +/-   ##
==========================================
+ Coverage   48.95%   48.98%   +0.03%     
==========================================
  Files         445      445              
  Lines       42844    42848       +4     
==========================================
+ Hits        20973    20988      +15     
+ Misses      21871    21860      -11     

Files	Coverage Δ
framework/widgets/Menu.php	59.34% <60.00%> (+10.61%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[samdark]

@atrandafir is that possible to add some tests for this case so it's not broken again?

[samdark]

Also would need a line for CHANGELOG to merge it.

[atrandafir]

@samdark added the tests and also updated the CHANGELOG

Had to change the mock from application to webApplication to find a way to actually make the widget check for real urls in order to be able to test the active item behavior.

[samdark]

👍