Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yii server and add tests. #20021

Merged
merged 9 commits into from
Oct 21, 2023
Merged

Fix yii server and add tests. #20021

merged 9 commits into from
Oct 21, 2023

Conversation

terabytesoftw
Copy link
Member

@terabytesoftw terabytesoftw commented Oct 20, 2023 •
edited
Loading

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Issue #20006 
Fatal error: Uncaught ValueError: Path cannot be empty in [no active file]:0 Stack trace: #0 {main} thrown in [no active file] on line 0

@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5eeb12f) 49.02% compared to head (bee7f72) 49.10%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20021      +/-   ##
==========================================
+ Coverage   49.02%   49.10%   +0.08%     
==========================================
  Files         445      445              
  Lines       42849    42836      -13     
==========================================
+ Hits        21005    21034      +29     
+ Misses      21844    21802      -42
Files Coverage Δ
framework/console/controllers/ServeController.php 87.50% <57.14%> (+76.17%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terabytesoftw terabytesoftw marked this pull request as ready for review October 20, 2023 16:17
@bizley
Copy link
Member

bizley commented Oct 21, 2023

Just a changelog line, please.

@bizley bizley merged commit bc56545 into yiisoft:master Oct 21, 2023
49 checks passed
@terabytesoftw terabytesoftw deleted the yii-serve-fix branch October 22, 2023 09:59
@terabytesoftw terabytesoftw mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bizley bizley bizley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terabytesoftw @bizley