Explain why DI fails sometimes and how to fix this (#20010) #20108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
skepticspriggan
commented
Jan 27, 2024
skepticspriggan
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues | #20010 |
PR Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20108 +/- ##
=======================================
Coverage 48.02% 48.02%
=======================================
Files 445 445
Lines 43892 43892
=======================================
Hits 21080 21080
Misses 22812 22812 ☔ View full report in Codecov by Sentry. |
samdark
reviewed
Jan 29, 2024
docs/guide/concept-di-container.md
Outdated
| @@ -396,6 +396,18 @@ class HotelController extends Controller | |||
| } | |||
| ``` | |||
|
|
|||
| Note that not all core code supports DI due to performance concerns. You can add support if needed by overriding | |||
There was a problem hiding this comment.
I think that's correct for AR only. Are there any other cases?
There was a problem hiding this comment.
I could not find other cases.
I wrote it this way because it seemed the most durable. It is technically correct now and would also be true if a case is discovered or added in the future.
There was a problem hiding this comment.
I'd move this note into AR guide instead.
samdark
approved these changes
Feb 16, 2024
|
Thanks. |
|
Glad to contribute |
skepticspriggan
deleted the
20010-explain-why-di-fails-sometimes-and-how-to-fix-this
branch
skepticspriggan
added a commit
to skepticspriggan/yii2
that referenced
this pull request
Mar 23, 2024
…iisoft#20108) * Explain why DI fails sometimes and how to fix this (yiisoft#20010) * Explain why AR does not support DI by default and how to support it (yiisoft#20010)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.