Correctly parse boolean keywords (e.g. used in SQLite) in \yii\db\ColumnSchema::typecast()
#20122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite uses keywords
TRUE
andFALSE
for boolean values (https://www.sqlite.org/datatype3.html).When creating a column with a default value of
false
this keyword is returned literally when getting the table definition. E.g.:\Yii::$app->db->getSchema()->createColumnSchemaBuilder(Schema::TYPE_BOOLEAN)->defaultValue(false)
.When this string is pared it always results in a
true
value (in PHPvar_dump((bool)'false');
results inbool(true)
).This PR fixes the boolean parsing by ensuring the value is not the (case insensitive) string 'false'.