Fix #20195 Do not set parts of ColumnSchema->dbType values into Colum… #20197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ColumnSchema->type for mssql less then version 2017
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20197 +/- ##
=========================================
Coverage 64.98% 64.99%
+ Complexity 11393 11392 -1
=========================================
Files 430 430
Lines 36924 36921 -3
=========================================
Hits 23995 23995
+ Misses 12929 12926 -3 ☔ View full report in Codecov by Sentry. |
terabytesoftw
approved these changes
Jun 11, 2024
|
What version of |
2012 😭️ |
Arhell
approved these changes
Jun 12, 2024
Tigrov
approved these changes
Jun 12, 2024
|
@axeltomasson Could you clarify: is this a regression in 2.0.50 or was it also broken in 2.0.49? |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nSchema->type for mssql less then version 2017