-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downloader for the Mozilla Common Voice Datasets #120
Conversation
I do not understand the last DeepSource error (no self). If I remove self the tests do not run at all |
Nice, thank you. Regarding the URL availability, I think it is not good to have the tests for that in the same unit tests. Could you please merge the fix-commits in to the other one? |
The fix commits are squashed, the "Added Test" commit is removed, DeepSource is ignored 😄 and the Test is also removed. Should look fine now. |
In the mean time I have worked through all the deepsource issues in the codebase. |
Rebase onto master is done, checked with flake8 and DeepSource looks good 👍 |
Travis says
You know how to handle that problem? |
I guess has something to do with numba/llvmlite#551, they dropped py35 support. We could try to fix on an old version (It is not fixed because it is only a subdependency of librosa -> numba). But it is not the first time that llvmlite version messes up the builds. If I remember correctly it failed last time because we fixed on a specific version. |
If audiomate will carry on support python 3.5 another library is needed if I understand it right.. Using an old version is maybe a possibility, but I sounds not right. Not supporting python 3.5 is maybe also no possibility.. |
The joy of transitive dependencies 🤢 I did not find any reasoning why llvmlite dropped Python 3.5 support. Following their lead is an option considering Python 3.5 reaches its EOL in September. |
5 months left. So maybe it's a possibility to just drop the support for Python 3.5... Otherwise, I think, it would be a bit of work to fix that.. But i just suppose that.. |
This 3 commits add support for downloading the Common Voice datasets. All today available languages are supported. If new languages will be added, the provided tests fail or a new release of the Common Voice dataset is available then the DOWNLOAD_URLS need to be modified to include/replace the new/broken URL's.
->
Dataset availability tests (checks if HTTP HEAD Status Code is 200) are added