feat: transmitting data is broadcast across zippers by default #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov Report
@@ Coverage Diff @@
## master #612 +/- ##
==========================================
+ Coverage 65.21% 65.83% +0.61%
==========================================
Files 40 40
Lines 3105 3091 -14
==========================================
+ Hits 2025 2035 +10
+ Misses 940 918 -22
+ Partials 140 138 -2
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fanweixiao
approved these changes
Sep 19, 2023
fanweixiao
changed the title
wujunzhuo
added a commit
that referenced
this pull request
Sep 19, 2023
# Description By the pr #612 all data frames will be forwarded to downstream zippers. Therefore the loop protection is necessary for zipper mesh scenario: avoid a data frame being processed by a unique SFN multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the source
Broadcastmethod and theWritemethod sends data as a broadcast.Impact
Broadcast(tag uint32, data []byte) error