Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llm-beidge): empty system prompt with overwriting will not overwrite #971

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

woorui
Copy link
Collaborator

@woorui woorui commented Dec 19, 2024

No description provided.

@woorui woorui requested a review from venjiang December 19, 2024 12:54
@woorui woorui self-assigned this Dec 19, 2024
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
yomo ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 4:04am

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.79%. Comparing base (9115f6c) to head (8f5a1af).

Files with missing lines Patch % Lines
pkg/bridge/ai/provider/anthropic/provider.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #971       +/-   ##
===========================================
- Coverage   71.92%   45.79%   -26.13%     
===========================================
  Files           5       97       +92     
  Lines         374     6723     +6349     
===========================================
+ Hits          269     3079     +2810     
- Misses         96     3446     +3350     
- Partials        9      198      +189     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

go.mod Outdated Show resolved Hide resolved
Co-authored-by: venjiang <[email protected]>
@woorui woorui changed the base branch from master to fix/anthropic-provider December 20, 2024 04:02
@woorui woorui merged commit 412b632 into fix/anthropic-provider Dec 20, 2024
3 checks passed
@woorui woorui deleted the fix/sys-prompt branch December 20, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants