Skip to content
This repository has been archived by the owner on Jan 10, 2020. It is now read-only.

Not possible to include js files referenced by relative path in test files #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

samyhrer
Copy link

@samyhrer samyhrer commented Oct 3, 2012

Returning absolute paths broke the ability to include js files
referenced by relative path in test files

Returning absolute paths broke the ability to include js files
referenced by relative path in test files
@davglass
Copy link
Member

davglass commented Oct 3, 2012

I'll take a look at this, this was added to support Windows so I need to make sure this doesn't break that ;)

@davglass
Copy link
Member

davglass commented Oct 3, 2012

Do you have a test case for this? I've tested it locally without modification and it seems to work as expected. I'd like to see what I'm missing with this.

@samyhrer
Copy link
Author

samyhrer commented Oct 4, 2012

I'm having a setup with this directory structure and these files:

/src/test.js
/test/rel.html

Running
grover test/**/*.html
throws "javascript error script timeout" after a while.

Contents of rel.html:

<!DOCTYPE HTML>
<html>
<head>
    <meta http-equiv="content-type" content="text/html; charset=utf-8">
    <title>Basic Usage Example</title>
    <script src="http://yui.yahooapis.com/3.6.0/build/yui/yui-min.js"></script>
</head>
<body>
    <script src="../src/test.js"></script>
</body>
</html>

The use case is to be able to reference both test-scripts as well as other js-dependencies by relative path

…atform

On the windows platform it was not possible to start test this way:
grover <path to test file> <path to test file>
Glob patterns such as /**/*.html was not supported on *nix-platforms.
This is now introduced by the -g <pattern> argument.
@SebastianStiehl
Copy link

That works for me too. Thx samyrer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants