Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor imports for dbt 1.8.0+ #149

Merged
merged 3 commits into from
May 21, 2024
Merged

Conversation

ryan-pip
Copy link
Contributor

Fix import paths for dbt common and adapter components for dbt 1.8.0.

@syou6162
Copy link
Contributor

@ryan-pip Can you pull the latest from the main branch and add dbt 1.8 to the test?

The reason for this addition is to make sure that this pull request works correctly with dbt 1.8 and that dbt 1.7 and below also work fine. FYI @z3z1ma

@ryan-pip
Copy link
Contributor Author

Did you want me to add dbt-version 1.8.0 to the versions that will be tested as well?

@syou6162
Copy link
Contributor

@ryan-pip Yes, I would like you to do so, and to ensure that dbt-osmosis works with multiple dbt-core versions, we would like to add 1.8.0 to our test subject. This would make dbt-osmosis more maintainable.

@ryan-pip
Copy link
Contributor Author

@syou6162, Tests have been added and are passing. Anything else needed here?

@syou6162
Copy link
Contributor

@ryan-pip Thanks for adding the test!

@z3z1ma We have confirmed on CI that it works fine with 1.8 and versions prior to 1.7, so it looked good. Could you please review it?

@z3z1ma
Copy link
Owner

z3z1ma commented May 21, 2024

LGTM thanks, I will cut a new release on PyPI and get the changelog, readme, and docs site updated.

@z3z1ma z3z1ma merged commit 8c5781c into z3z1ma:main May 21, 2024
4 checks passed
@FrankTub
Copy link

FrankTub commented Jun 4, 2024

@z3z1ma , when can we expect a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants