Print markdown symbols in IRC for inline code blocks, bold, etc. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally, this would be configured in the settings, but for now it is unconditional. In many IRC clients, including goguma/gamja/senpai (all the clients with good support for soju bouncers like <https://chat.sr.ht>), the formatting Dis4IRC previously used for this is invisible. For them, preserving the backticks, starts, etc, is very helpful. Partially fixes zachbr#81
ilyagr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, this would be configured in the settings, but for now it is unconditional.
For this reason, I'll make this a draft PR, to be used by anybody who needs this. Feel free to take it as is if you feel like it, or I might improve it later.
In many IRC clients, including goguma/gamja/senpai (all the clients with good support for soju bouncers like https://chat.sr.ht), the formatting Dis4IRC previously used for this is invisible. For them, preserving the backticks, starts, etc, is very helpful.
Partially fixes #81. (I did not address multi-line code blocks)
Here's what the IRC side of this looks like for gamja (default client for chat.sr.ht):
Before this PR, there would not be backticks or stars in there. I filed an issue about it, no idea if it would be fixed. (And I'm not familiar enough with IRC formatting to fix it myself)
Here's what this PR looks like for a client that supports formatting (Textual, takes effort to make work with soju and the interaction glitches):
I think this is not too bad. In fact, the monospace in this client is not very easy to see without backticks since it doesn't change the background for monospace by default.